feat: Frames Client #213
feat: Frames Client #213
Conversation
Added Frames package port from JS Bumped protos library
alexrisch
force-pushed
the
ar/frames-client
branch
from
4f19e12 to
4ec386d
Compare
Updated handling Added tests
Fixed lint on builds
Fixed lint on builds
| val state: String? | ||
| ) | ||
|
|
||
| data class GetMetadataResponse( |
There was a problem hiding this comment.
It's going to make usability much better if this also included the frameInfo field which does a lot of the parsing of the extracted tags for you and assembles it into a nice object. Could happen in a follow-up PR.
library/src/main/java/org/xmtp/android/library/frames/FramesClient.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/org/xmtp/android/library/frames/FramesClient.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/org/xmtp/android/library/frames/FramesClient.kt
Outdated
Show resolved
Hide resolved
| } | ||
| is ConversationActionInputs.Dm -> { | ||
| val dmInputs = inputs.conversationInputs.inputs | ||
| val conversationTopic = dmInputs.conversationTopic ?: throw InvalidArgumentsError() |
There was a problem hiding this comment.
Can we throw an XMTPException instead. This helps integrators catch exceptions being thrown from our SDK easier.
| val conversationTopic = dmInputs.conversationTopic ?: throw InvalidArgumentsError() | |
| val conversationTopic = dmInputs.conversationTopic ?: throw XMTPException("No conversation topic") |
library/src/main/java/org/xmtp/android/library/frames/FramesErrors.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/org/xmtp/android/library/frames/OpenFramesProxy.kt
Outdated
Show resolved
Hide resolved
library/src/androidTest/java/org/xmtp/android/library/FramesTest.kt
Outdated
Show resolved
Hide resolved
| if (inputText != null) { | ||
| frame.inputText = inputText | ||
| } | ||
| if (state != null) { | ||
| frame.state = state | ||
| } |
There was a problem hiding this comment.
Is there a reason you null check here? Seems like state and inputText are okay with null being set?
| if (inputText != null) { | |
| frame.inputText = inputText | |
| } | |
| if (state != null) { | |
| frame.state = state | |
| } | |
| frame.inputText = inputText | |
| frame.state = state |
There was a problem hiding this comment.
They are not, it errors if the state is null or inputText is null, instead they use the default values
There was a problem hiding this comment.
Ahh okay now I see you did this in iOS
let state = inputs.state ?? ""
Then to clean this up what about this
| if (inputText != null) { | ||
| frame.inputText = inputText | ||
| } | ||
| if (state != null) { | ||
| frame.state = state | ||
| } |
There was a problem hiding this comment.
Ahh okay now I see you did this in iOS
let state = inputs.state ?? ""
Then to clean this up what about this
| val frameUrl = inputs.frameUrl | ||
| val buttonIndex = inputs.buttonIndex | ||
| val inputText = inputs.inputText | ||
| val state = inputs.state |
There was a problem hiding this comment.
| val state = inputs.state | |
| val state = inputs.state ?: "" |
| val opaqueConversationIdentifier = buildOpaqueIdentifier(inputs) | ||
| val frameUrl = inputs.frameUrl | ||
| val buttonIndex = inputs.buttonIndex | ||
| val inputText = inputs.inputText |
There was a problem hiding this comment.
| val inputText = inputs.inputText | |
| val inputText = inputs.inputText ?: "" |
Just to match iOS and remove the null check inline
Added Frames package port from JS
Bumped protos library